Fix for #134 #135
Merged
Fix for #134 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meteor 1.7 uses v3 of the Mongo driver, which changes the errors thrown by bulk operations. Meteor uses .insert() rather than .insertOne(), so is affected. As a result, with Meteor 1.7, the error's name is BulkWriteError, not MongoError. This commit makes the check compatible with both v2 and v3 of the Mongo driver, by checking just the error code, not the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
Fix error handling for Meteor 1.7.
Meteor 1.7 uses v3 of the Mongo driver, which changes
the errors thrown by bulk operations. Meteor uses .insert()
rather than .insertOne(), so is affected. As a result, with
Meteor 1.7, the error's name is BulkWriteError, not MongoError.
This commit makes the check compatible with both v2 and v3 of the
Mongo driver, by checking just the error code, not the name.