Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination loses page number #70

Closed
epicmonkey opened this issue Dec 11, 2013 · 2 comments
Closed

Pagination loses page number #70

epicmonkey opened this issue Dec 11, 2013 · 2 comments
Labels
bug
Milestone
0.0.11

Comments

@epicmonkey
Copy link
Member

If there are more than two pages available and a user clicks on "Older items" link, Pepyatka will load older entries however URL won't be changed. As a result if she refreshes a page Pepyatka will lose that page and will render the very first one.

Emberjs has query-params feature available in canary builds (pull request for the reference: emberjs/ember.js#3182, however it's not a part of 1.3 release) and there are instructions how to use it: http://emberjs.com/guides/routing/query-params/.

We can introduce query parameter "page" like it's done in will_paginate Rails module.
@epicmonkey
Copy link
Member Author

It's landed and is a part of ember 1.7.0 release.

@epicmonkey epicmonkey mentioned this issue Dec 1, 2014
Closed
@epicmonkey
Copy link
Member Author

This is for the frontend. See linked story.

@epicmonkey epicmonkey modified the milestones: Uncategorized, 0.0.11 Mar 24, 2015
davidmz pushed a commit to davidmz/freefeed-server-pepyatka that referenced this issue May 29, 2016
Merge pull-request pepyatka#70 from FreeFeed:babel6 to stable
30861a9 
NodeJS 6.0 + Babel6
Babel6 can handle our code finally.

[close pepyatka#70]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.0.11
Development

No branches or pull requests
1 participant
@epicmonkey