Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pydantic argparse cli and Refactor Looper Tests #472

Merged
merged 58 commits into from
Mar 12, 2024
Merged

Adding pydantic argparse cli and Refactor Looper Tests #472

merged 58 commits into from
Mar 12, 2024

Conversation

donaldcampbelljr
Copy link
Contributor

@donaldcampbelljr donaldcampbelljr commented Feb 27, 2024 •
edited
Loading

This PR accomplishes these major tasks:

CLI

TESTS

TODO:

  • - adding the remaining arguments
  • - ensure they work
  • - remove old cli
  • - fix tests

@donaldcampbelljr
Copy link
Contributor Author

Some misc notes on usage by example:
looper.cli_pydantic init --force-yes
looper.cli_pydantic --looper-config .looper_project.yaml runp
looper.cli_pydantic --looper-config .looper.yaml rerun

@donaldcampbelljr
Copy link
Contributor Author

I had to add init-piface as init_piface. Will revisit.

@donaldcampbelljr
Copy link
Contributor Author

Commands are added.

@donaldcampbelljr
switch to using cli_pydantic only
24bdbbd
@donaldcampbelljr
fix bug with getattr being False with default of 0
bdd5ee2
@donaldcampbelljr
fix test via test_args
89f0da7
@donaldcampbelljr
fix more tests, rethink test_args expansion
c165de3
@donaldcampbelljr
Merge branch 'drc_feature-pydantic-argparse-cli' into dev_rethink_tes…
b68cb8c 
…ting
@donaldcampbelljr
Merge pull request #473 from pepkit/dev_rethink_testing
935ce5a 
Dev rethink testing
@donaldcampbelljr
lint
d59de5e
@donaldcampbelljr
re-add lumpj to pydantic arguments
973e660
@donaldcampbelljr
Fix portable argument for report
1e2e50b
@donaldcampbelljr
Add tests skipping for tests using outdated pep
e924682
@donaldcampbelljr
Switch to pydantic2-argparse
066e661
@donaldcampbelljr
Fix comprehensive looper-pipestat test
eaafb64
@donaldcampbelljr
Fix comprehensive looper-basic test
5287863
@donaldcampbelljr
attempt to fix selecting multiple flags, does not work
2249711
@donaldcampbelljr
Add exc_flag and sel_flag to Run command as a poc #438
9fdf85a
@donaldcampbelljr
Move all optional arguments to be under each command as appropriate #438
debb45c
@donaldcampbelljr donaldcampbelljr mentioned this pull request Mar 11, 2024
Merged
@donaldcampbelljr donaldcampbelljr marked this pull request as ready for review March 11, 2024 18:41
@donaldcampbelljr donaldcampbelljr changed the title Continue enhancement adding pydantic argparse cli Adding pydantic argparse cli and Refactor Looper Tests Mar 11, 2024
@nsheff
Copy link
Contributor

nsheff commented Mar 12, 2024

I think you're collecting other changes on this PR -- I think you may need to rebase the dev branch into feature-pydantic-argparse-cli, because the incoming branch here is carrying with it a bunch of unrelated updates, making it hard to review the PR

@donaldcampbelljr
Merge branch 'feature-pydantic-argparse-cli' into drc_feature-pydanti…
246c5ef 
…c-argparse-cli

# Conflicts:
#	looper/looper.py
#	requirements/requirements-all.txt
@donaldcampbelljr
Copy link
Contributor Author

I merged the downstream changes into target branch to make it a bit more legible.

@donaldcampbelljr
Copy link
Contributor Author

Partially addresses #464, though there still is work to be done with writing more comprehensive smoketests

nsheff
nsheff approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@nsheff nsheff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, I made some suggestions.

looper/cli_pydantic.py Show resolved Hide resolved
looper/cli_pydantic.py Show resolved Hide resolved
looper/cli_pydantic.py Outdated Show resolved Hide resolved
looper/cli_pydantic.py Outdated Show resolved Hide resolved
looper/const.py Outdated Show resolved Hide resolved
looper/looper.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@donaldcampbelljr donaldcampbelljr merged commit a3a736d into feature-pydantic-argparse-cli Mar 12, 2024
1 check passed
@donaldcampbelljr donaldcampbelljr mentioned this pull request Mar 12, 2024
Merged
@donaldcampbelljr donaldcampbelljr deleted the drc_feature-pydantic-argparse-cli branch August 19, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsheff nsheff nsheff approved these changes

@khoroshevskyi khoroshevskyi Awaiting requested review from khoroshevskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donaldcampbelljr @nsheff