Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looper cli is not taking priority if cli modifiers are used in looper config #518

Open
donaldcampbelljr opened this issue Aug 22, 2024 · 3 comments
Milestone

Comments

@donaldcampbelljr
Copy link
Contributor

if i use looper with a limit command
looper run --limit 2

but then place this in my looper config:

pep_config: project/project_config.yaml
output_dir: "results"
pipeline_interfaces:
  - pipeline/pipeline_interface.yaml
cli:
  run:
    limit: 1

The config file takes priority but it should be the other way around. The CLI should always take priority.

@donaldcampbelljr
Copy link
Contributor Author

Ok, I think I see where the problem is located.

In function enrich_args_via_cfg, we take args from the CLI + any default args and then overwrite them based on what has been provided in other locations.

Here is a problem though, if I flip the sequence and have the og arguments take priority, then the non-user supplied default values will overwrite those provided in the config files.

@nsheff
Copy link
Contributor

nsheff commented Aug 23, 2024

Previous versions of looper had the correct behavior, so the change must have something to do with the new arguments system.

donaldcampbelljr added a commit that referenced this issue Aug 23, 2024
@donaldcampbelljr
Copy link
Contributor Author

I've pushed a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants