Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lump and lumpn defaults #108

Closed
nsheff opened this issue Apr 24, 2019 · 1 comment
Closed

lump and lumpn defaults #108

nsheff opened this issue Apr 24, 2019 · 1 comment
Assignees
@stolarczyk
Labels
bug Something isn't working
Milestone
0.13.0

Comments

@nsheff
Copy link
Contributor

nsheff commented Apr 24, 2019

the caravel defaults for lump and lumpn appear to be the maximum; they don't match the defaults for looper (which are off)
@nsheff nsheff added the bug Something isn't working label Apr 24, 2019
@stolarczyk stolarczyk added this to the 0.2.1 milestone Apr 29, 2019
stolarczyk added a commit to pepkit/looper that referenced this issue May 1, 2019
@stolarczyk
update defaults for HMTL CLI parsers, addresses pepkit/caravel#108
82ccef5
@stolarczyk
Copy link
Member

As discussed with @nsheff, the options that are off (None) by default will be inactive sliders/checkboxes in the future version.

The workaround for the problem raised here is to set (just in caravel) the defaults of lumpn and lump to 1 and 0, respectively. These values should mimic the looper "off" behavior for now.

@stolarczyk stolarczyk mentioned this issue May 1, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stolarczyk stolarczyk

Labels
bug Something isn't working
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
2 participants
@nsheff @stolarczyk