Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Codec requirement by an Encoder requirement #107

Merged
merged 1 commit into from
May 22, 2018
Merged

Replace Codec requirement by an Encoder requirement #107

merged 1 commit into from
May 22, 2018

Conversation

BenFradet
Copy link
Contributor

I didn't understand why requests with body needed a whole Codec so I replaced it with only Encoder.

@codecov
Copy link

codecov bot commented May 15, 2018

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   69.26%   69.26%           
=======================================
  Files          22       22           
  Lines         615      615           
  Branches        6        6           
=======================================
  Hits          426      426           
  Misses        189      189
Impacted Files Coverage Δ
core/shared/src/main/scala/hammock/Hammock.scala 72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47433b1...8ed410e. Read the comment docs.

@pepegar
Copy link
Owner

pepegar commented May 18, 2018

Heya @BenFradet! Thanks for this!

Currently I'm away from a computer but will get to review this on Monday. Sorry for the delay!

Cheers!

@pepegar
Copy link
Owner

pepegar commented May 22, 2018

LGTM, thanks for this @BenFradet !

@pepegar pepegar merged commit 1a57d92 into pepegar:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants