Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

334 autogenerate vorlagepy #402

Merged
merged 11 commits into from
Aug 8, 2024
Merged

334 autogenerate vorlagepy #402

merged 11 commits into from
Aug 8, 2024

Conversation

SepplL
Copy link
Contributor

@SepplL SepplL commented Aug 5, 2024

This is a first idea for auto-generating the vorlage.py from solution file.
Possible improvements:

  • make automated targets with more make-magic and better file referencing
  • skip dirs and vorlage if not necessary, i.e. better checking for # begin ... # end in solution file
  • possible multiple files, benefiting from better file reference

@SepplL SepplL linked an issue Aug 5, 2024 that may be closed by this pull request
Autogenerate "vorlage.py" from "loesung.py" #334
Closed
@SepplL
Copy link
Contributor Author

SepplL commented Aug 5, 2024

currently 1-python works, more to come

@SepplL SepplL requested review from aknierim, chrbeckm and maxnoe August 5, 2024 15:16
aknierim
aknierim reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@aknierim aknierim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

SepplL added 6 commits August 5, 2024 17:34
@SepplL
generate vorlagen for 2-numpy
6145fa0 
also making all comments `flake-8` compatible to prevent commits from
aborting due to pre-hook warnings.
@SepplL
include 3-matplotlib
ef4c4b3 
although not strictly necessary, include dir to make build process
consistent to other dirs as well
@SepplL
more generalised targets
59a2817 
trying to make the build process more general and robust
@SepplL
add 4-scipy
40ae9cd 
also make own code more flake8 complient

changed ambigous variable name I
@SepplL
add 5-uncertainties
f094e38 
flake8 adjustments:
- import at top of file
- renamed unumpy.sin to usin with second sin import later
- shorter comment line
@SepplL
adding 8-all
6d722df
@SepplL SepplL marked this pull request as ready for review August 6, 2024 12:19
@aknierim
Copy link
Member

aknierim commented Aug 6, 2024

Works for me

@chrbeckm chrbeckm merged commit f924969 into main Aug 8, 2024
1 check passed
@chrbeckm chrbeckm deleted the 334-autogenerate-vorlagepy branch September 29, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknierim aknierim aknierim approved these changes

@chrbeckm chrbeckm Awaiting requested review from chrbeckm

@maxnoe maxnoe Awaiting requested review from maxnoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autogenerate "vorlage.py" from "loesung.py"
3 participants
@SepplL @aknierim @chrbeckm