-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execution circuit breaker #3669
Conversation
d949472
to
2ac6b0c
Compare
Will do a review on the concrete implementation, but first high-level comment: this approach is clean and I think that it follows what @hdevalence outlined on discord: a top level counter that increments function calls to I think my preference would be for more intrusive metering, where we reach deep into |
crates/core/component/dex/src/component/router/route_and_fill.rs
Outdated
Show resolved
Hide resolved
use penumbra_proto::{core::component::dex::v1alpha1 as pb, DomainType, TypeUrl}; | ||
|
||
#[derive(Debug, Clone, Default)] | ||
pub struct AssetTallies { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't used AFAICT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is preliminary for the value circuit breaker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved some comments
This adds a circuit break mechanism to the DEX that bounds the maximum number of path searches and position executions for any given batch swap during a block, to prevent potentially unbounded looping.
Closes #3303