Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: fix out of date note commitment docs, add closing parentheses #2866

Merged
merged 1 commit into from
Jul 24, 2023
Merged

spec: fix out of date note commitment docs, add closing parentheses #2866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/protocol/src/protocol/action_descriptions/delegator_vote.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ The zk-SNARK also certifies that the commitment index of the start position is z

The zk-SNARK certifies that the note commitment $cm$ was derived as:

$cm = hash_5(ds, (rcm, v, ID, B_d, pk_d)$.
$cm = hash_6(ds, (rcm, v, ID, B_d, pk_d, ck_d))$.

using the above witnessed values and where `ds` is a constant domain separator:

Expand Down
2 changes: 1 addition & 1 deletion docs/protocol/src/protocol/action_descriptions/outputs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ And the corresponding public inputs:

The zk-SNARK certifies that the public input note commitment $cm$ was derived as:

$cm = hash_5(ds, (rcm, v, ID, B_d, pk_d)$.
$cm = hash_6(ds, (rcm, v, ID, B_d, pk_d, ck_d))$.

using the above witnessed values and where `ds` is a constant domain separator:

Expand Down
2 changes: 1 addition & 1 deletion docs/protocol/src/protocol/action_descriptions/spend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ We require each one of the following integrity properties to hold only for notes

The zk-SNARK certifies that for non-zero values $v \ne 0$, the note commitment $cm$ was derived as:

$cm = hash_5(ds, (rcm, v, ID, B_d, pk_d)$.
$cm = hash_6(ds, (rcm, v, ID, B_d, pk_d, ck_d))$.

using the above witnessed values and where `ds` is a constant domain separator:

Expand Down
2 changes: 1 addition & 1 deletion docs/protocol/src/protocol/action_descriptions/swap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ The zk-SNARK certifies that the public input swap commitment $scm$ was derived a

$scm_{inner} = hash_4(ds, (ID_1, ID_2, v_1, v_2))$

$scm = hash_7(ds, (rseed, v_f, ID_{v_f}, B_d, pk_d, \mathsf{ck_d}, scm_{inner})$.
$scm = hash_7(ds, (rseed, v_f, ID_{v_f}, B_d, pk_d, \mathsf{ck_d}, scm_{inner}))$.

using the above witnessed values and where `ds` is a constant domain separator:

Expand Down
6 changes: 3 additions & 3 deletions docs/protocol/src/protocol/action_descriptions/swap_claim.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ The zk-SNARK certifies that the witnessed swap commitment $scm$ was derived as:

$scm_{inner} = hash_4(ds, (ID_1, ID_2, \Delta_1, \Delta_2))$

$scm = hash_7(ds, (rseed, v_f, G_{v_f}, B_d, pk_d, \mathsf{ck_d}, scm_{inner})$.
$scm = hash_7(ds, (rseed, v_f, G_{v_f}, B_d, pk_d, \mathsf{ck_d}, scm_{inner}))$.

using the above witnessed values and where `ds` is a constant domain separator:

Expand Down Expand Up @@ -102,9 +102,9 @@ using the correct batch swap output data.

The zk-SNARK certifies that the note commitments $cm_1$ and $cm_2$ were derived as:

$cm_1 = hash_5(ds, (rcm_1, \Lambda_{1i}, ID_1, B_d, pk_d)$
$cm_1 = hash_6(ds, (rcm_1, \Lambda_{1i}, ID_1, B_d, pk_d, ck_d))$

$cm_2 = hash_5(ds, (rcm_2, \Lambda_{2i}, ID_2, B_d, pk_d)$
$cm_2 = hash_6(ds, (rcm_2, \Lambda_{2i}, ID_2, B_d, pk_d, ck_d))$

using the above witnessed values and where `ds` is a constant domain separator:

Expand Down