Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arb execution does not update value circuit breaker #4113

Closed
Tracked by #1724
, #4402
...
hdevalence opened this issue Mar 26, 2024 · 2 comments · Fixed by #4428
Closed
Tracked by #1724
, #4402
...

Arb execution does not update value circuit breaker #4113

hdevalence opened this issue Mar 26, 2024 · 2 comments · Fixed by #4428
Assignees
@erwanor
Labels
A-dex Area: Relates to the dex C-bug Category: a bug consensus-breaking breaking change to execution of on-chain data E-easy Effort: Easy _P-high High priority _P-V1 Priority: slated for V1 release
Milestone
Sprint 7

Comments

@hdevalence
Copy link
Member

Describe the bug

The arb execution doesn't update the value circuit breaker. Since it burns the tokens, they should be debited from the DEX balance.
@hdevalence hdevalence added E-easy Effort: Easy consensus-breaking breaking change to execution of on-chain data labels Mar 26, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Mar 26, 2024
@erwanor erwanor mentioned this issue Apr 4, 2024
Open
65 tasks
@erwanor erwanor added the A-dex Area: Relates to the dex label Apr 16, 2024
@aubrika aubrika added _P-high High priority C-bug Category: a bug _P-V1 Priority: slated for V1 release labels Apr 17, 2024
@hdevalence hdevalence mentioned this issue Apr 26, 2024
Closed
@erwanor erwanor self-assigned this May 8, 2024
@aubrika aubrika added this to the Sprint 7 milestone May 14, 2024
@conorsch conorsch mentioned this issue May 16, 2024
Closed
40 tasks
@erwanor
Copy link
Member

erwanor commented May 20, 2024

I'm going to tackle this immediately after #4413 since they both interface with pd-migrate

@aubrika aubrika moved this from Backlog to Todo in Penumbra May 20, 2024
@hdevalence
Copy link
Member Author

I don't think we need a migration here, we just need to fix the code.

@erwanor erwanor mentioned this issue May 21, 2024
Merged
1 task
erwanor added a commit that referenced this issue May 21, 2024
@erwanor
dex: deduct arb surplus from component VCB (#4428)
c7e1ad8 
## Describe your changes

Close #4113

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

> This is consensus-breaking and state-breaking, but does not require
any migration to heal the dex vcb
@github-project-automation github-project-automation bot moved this from Todo to Done in Penumbra May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwanor erwanor

Labels
A-dex Area: Relates to the dex C-bug Category: a bug consensus-breaking breaking change to execution of on-chain data E-easy Effort: Easy _P-high High priority _P-V1 Priority: slated for V1 release
Projects
Penumbra
Archived in project
Milestone
Sprint 7
Development

Successfully merging a pull request may close this issue.

dex: deduct arb surplus from component VCB penumbra-zone/penumbra
3 participants
@hdevalence @erwanor @aubrika