You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is an open bug in reqwest (#668): it is an internal expectation that any valid Url is also a valid Uri. Per the current logic for parsing Uris and Urls, this is not always the case. The corner case that affects us is that when the length of the Url exceeds a certain threshold (unclear of the exact limit at time of writing), an internal .expect() fails in request, resulting in:
thread 'main' panicked at 'a parsed Url should always be a valid Uri: InvalidUri(TooLong)', /Users/$USER/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/reqwest-0.11.9/src/into_url.rs:70:14
We encounter this issue whenever we try to submit a transaction to the Tendermint RPC API which is sufficiently long to trigger this condition when included as hex-encoding in the URI, because we are using the URI-over-HTTP RPC API from Tendermint:
let rsp: serde_json::Value = reqwest::get(format!(
r#"http://{}:{}/broadcast_tx_sync?tx=0x{}"#,
self.node,
self.rpc_port,
hex::encode(&transaction.encode_to_vec())
))
.await?
.json()
.await?;
When the hex-encoding of the transaction is too long, the direct inclusion of that encoding in the URI of the GET request causes reqwest to panic.
This issue points to two things that need to be solved:
Transactions are limited in size by the arbitrary bound of the size of a URI, and
Transactions are often very very large.
This issue addresses (1); a follow-up issue will address (2).
Proposed solution to (1)
We should use the JSONRPC-over-HTTP endpoint for Tendermint instead of the URI-over-HTTP endpoint. This encodes the transaction body in the body of a POST, which can be arbitrarily large. See the documentation for the Tendermint RPC: https://docs.tendermint.com/master/rpc/.
The text was updated successfully, but these errors were encountered:
There is an open bug in
reqwest
(#668): it is an internal expectation that any validUrl
is also a validUri
. Per the current logic for parsingUri
s andUrl
s, this is not always the case. The corner case that affects us is that when the length of theUrl
exceeds a certain threshold (unclear of the exact limit at time of writing), an internal.expect()
fails inrequest
, resulting in:We encounter this issue whenever we try to submit a transaction to the Tendermint RPC API which is sufficiently long to trigger this condition when included as hex-encoding in the URI, because we are using the URI-over-HTTP RPC API from Tendermint:
penumbra/pcli/src/network.rs
Lines 18 to 26 in 1996412
When the hex-encoding of the transaction is too long, the direct inclusion of that encoding in the URI of the GET request causes
reqwest
to panic.This issue points to two things that need to be solved:
This issue addresses (1); a follow-up issue will address (2).
Proposed solution to (1)
We should use the JSONRPC-over-HTTP endpoint for Tendermint instead of the URI-over-HTTP endpoint. This encodes the transaction body in the body of a POST, which can be arbitrarily large. See the documentation for the Tendermint RPC: https://docs.tendermint.com/master/rpc/.
The text was updated successfully, but these errors were encountered: