forked from rapidsai/ucxx
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move
ucxx::Request
status setting to base class
Setting the status from a derived class before `callback()`, and, therefore `setStatus()`, can be dangerous in situations where the user code is not holding a reference to the request. In such cases, the user code may be checking for the status to change to immediately continue by releasing the request, when that happens and `setStatus()` is eventually called, that will be operating on an invalid `ucxx::Request` object.
- Loading branch information
Showing
3 changed files
with
5 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters