-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Local & Remote filters #60
Feature: Local & Remote filters #60
Conversation
… supported also in Linux (I do not see why this worked on win and not in Linux)
I needed to change from format.setForeground(QBrush(QColorConstants::LightGray)); to format.setForeground(QBrush(QColor("LightGray"))); bc the first option didn't compile on Linux (wtf!?) |
What change did u make in Travis? I am getting this when building
and yesterday at https://travis-ci.org/github/pentix/qjournalctl/builds/671358169?utm_source=github_status&utm_medium=notification it worked
|
I see no changes.... do you have any idea? |
Reopening to enforce a newer CI cycle |
Hello @pentix, Have you discarded adding these features? If the problem is about the CI, my plan is to shift to std rand to avoid increasing Qt version. |
Hi Asier No, sorry, I did not want to discard this. I deleted and pushed the old "windows-build" branch, which this PR was based upon, I'm quite short on time right now, I'll look over all those PRs and try to find a simple solution so we can make it work. Quite a while ago I started developing some features which kind of interfere with the filtering, so ideally I'd combine Btw.: GitHub does not let me reopen this, but since it's mentionend in #66, I won't forget it :) |
What?
This contribution fixex #59
The contribution includes
light-gray
Result
In case of having the remote filter enabled, the filter is made in remote
If in turn, thhe
remote filter
is disabled, the filter is made locally and the non-matching lines are displayed in gray