Silence annoying ltex error on no error #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeo
requested review from
matthieu-gendreau,
a team and
dumitraand
and removed request for
a team
matthieu-gendreau
approved these changes
Dec 10, 2024
| @@ -4,6 +4,12 @@ repos: | |||
| - id: check-hooks-apply | |||
| - id: check-useless-excludes | |||
|
|
|||
| - repo: https://github.com/shellcheck-py/shellcheck-py | |||
There was a problem hiding this comment.
😕 Is this related to this ltex?
| "$ltex_version" 2>&1 | | ||
| sed -E 's|(app/javascript/documentation/.*?\.md):|\1x:|g' || true) | ||
|
|
||
| echo "$output" | grep "SEVERE: java.io.IOException: Stream closed" >/dev/null || echo "$output" |
There was a problem hiding this comment.
💭 it could make it harder to debug if a future issue would trigger a java IOException that would be stripped from the output?
I don't know how I'd test pre-commit hooks with python in the first place. The dev workflow is pretty interactive locally by using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @matthieu-gendreau during his setup: https://pennylane-org.slack.com/archives/C02FA990G3E/p1733821498064659