Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Windows and macOS #88

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Test Windows and macOS #88

merged 3 commits into from
Jul 4, 2022

Conversation

yfukai
Copy link
Collaborator

@yfukai yfukai commented Jul 3, 2022

No description provided.

@yfukai yfukai changed the base branch from main to dev July 3, 2022 03:41
@yfukai yfukai marked this pull request as ready for review July 3, 2022 03:42
@yfukai
Copy link
Collaborator Author

yfukai commented Jul 3, 2022

https://stackoverflow.com/questions/57689387/equivalent-for-find-links-in-setup-py
using --find-links option in setup.cfg looks difficult for pip>0.20

@yfukai yfukai mentioned this pull request Jul 3, 2022
Closed
tdmorello
tdmorello approved these changes Jul 4, 2022
View reviewed changes
noxfile.py
@@ -1,5 +1,6 @@
"""Nox automation file."""

import platform
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never knew about the platform module!

@tdmorello tdmorello merged commit 294ea53 into peng-lab:dev Jul 4, 2022
@yfukai yfukai deleted the windows_support branch July 4, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdmorello tdmorello tdmorello approved these changes

@Nicholas-Schaub Nicholas-Schaub Awaiting requested review from Nicholas-Schaub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yfukai @tdmorello