Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds reference_id setting #1815

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

o087D
Copy link
Contributor

@o087D o087D commented Feb 3, 2025

Enables end user to set the value for 'reference_id' if operating as a server in stratum 1, as discussed in #1718

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.43%. Comparing base (badb4f1) to head (2f300a6).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
ntp-proto/src/config.rs 91.48% 4 Missing ⚠️
ntp-proto/src/system.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1815      +/-   ##
==========================================
+ Coverage   81.41%   81.43%   +0.01%     
==========================================
  Files          68       68              
  Lines       21610    21659      +49     
==========================================
+ Hits        17594    17637      +43     
- Misses       4016     4022       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@o087D o087D force-pushed the enable_reference_id_setting branch 2 times, most recently from 74dd7a0 to 1cea619 Compare February 3, 2025 19:20
@o087D o087D force-pushed the enable_reference_id_setting branch from 1cea619 to 5248ade Compare February 3, 2025 19:22
Copy link
Member

@davidv1992 davidv1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good design to me. Thanks for the contribution.

@davidv1992 davidv1992 requested a review from rnijveld February 6, 2025 12:37
@davidv1992
Copy link
Member

@rnijveld can you take a short look at this, in particular if you agree with the new setting name and placement?

@rnijveld
Copy link
Member

This looks good to me as well, I think the synchronization section is probably the best section for this!

@rnijveld rnijveld added this pull request to the merge queue Feb 13, 2025
Merged via the queue into pendulum-project:main with commit 582a86f Feb 13, 2025
23 checks passed
@rnijveld
Copy link
Member

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants