-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds reference_id setting #1815
Adds reference_id setting #1815
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1815 +/- ##
==========================================
+ Coverage 81.41% 81.43% +0.01%
==========================================
Files 68 68
Lines 21610 21659 +49
==========================================
+ Hits 17594 17637 +43
- Misses 4016 4022 +6 ☔ View full report in Codecov by Sentry. |
74dd7a0
to
1cea619
Compare
1cea619
to
5248ade
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good design to me. Thanks for the contribution.
@rnijveld can you take a short look at this, in particular if you agree with the new setting name and placement? |
This looks good to me as well, I think the synchronization section is probably the best section for this! |
Thanks for the contribution! |
Enables end user to set the value for 'reference_id' if operating as a server in stratum 1, as discussed in #1718