Add rustflags in cargo config #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
reviewed
Jul 22, 2024
.cargo/config.toml
Outdated
Comment on lines
1
to
2
| [env] | ||
| CARGO_BUILD_RUSTFLAGS="--cfg tokio_unstable" |
There was a problem hiding this comment.
Why are we not doing it like this? What's the difference?
There was a problem hiding this comment.
Oh my god, good catch.
There was a problem hiding this comment.
I think it'll behave just the same.
But yeah, I'll let it look similar to https://github.com/tokio-rs/console?tab=readme-ov-file#instrumenting-your-program
There was a problem hiding this comment.
Nice, can confirm that the compilation works for me with and without the allow-debugger feature.
gianfra-t
pushed a commit
that referenced
this pull request
Jul 24, 2024
* add rustflag in cargo config * add documentation of where the rustflags are set. * #543 (comment) * #543 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines the rustflags directly in
.cargo/config.tomlfile.This is required for
tokio-console. https://github.com/pendulum-chain/tasks/issues/343