Retry on rpc timeout response #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pendulum-chain/devs Although I think this could solve the issue, I was not able to trigger a |
ebma
approved these changes
May 2, 2024
|
The CI keeps failing on me 😕. Someone knows why could this be? |
|
Yes one of the previous was a failed build, very strange since it has been built many times already! |
gianfra-t
deleted the
516-make-vault-client-retry-submissions-for-rpc-timeout-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #516.
General Description
Upon receiving a
RequestTimeouterror, the client should retry sending the transaction. This will be done with the samebackoffused for other errors defined as "Skippable".Implementation
We add a method to identify the
RequestTimeouterror, and add it to the respective closures with the correspondingSkipretry policy.The client's existing timeout (for some transactions) should also be larger (currently 5 minutes) than the one returned by the unresponsive chain. For requests we will just retry until the backoff is exausted.