Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run benchmarks for custom pallets #497

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

bogdanS98
Copy link
Contributor

@bogdanS98 bogdanS98 commented Mar 13, 2024

Closes #496.

Still WIP as running benchmarks for vault-registry pallet results in panic:

at: spacewalk/pallets/vault-registry/src/benchmarking.rs:154
Error: Input("Error executing and verifying runtime benchmark: Runtime panicked: called Result::unwrap() on an Err value: Module(ModuleError { index: 21, error: [1, 0, 0, 0], message: Some(\"ExceedingVaultLimit\") })") Evicting failed runtime instance error=Runtime panicked: called Result::unwrap() on an Err value: Module(ModuleError { index: 21, error: [1, 0, 0, 0], message: Some("ExceedingVaultLimit") })

Fixed vault-registry benchmarks panic by setting the issue amount from 10000 to 5000 here.

@bogdanS98 bogdanS98 requested a review from a team March 13, 2024 14:10
@bogdanS98 bogdanS98 linked an issue Mar 13, 2024 that may be closed by this pull request
@bogdanS98 bogdanS98 changed the title Re-run benchmarks for most pallets Re-run benchmarks for custom pallets Mar 13, 2024
@ebma
Copy link
Member

ebma commented Mar 13, 2024

What's the error in the panic?

@bogdanS98
Copy link
Contributor Author

bogdanS98 commented Mar 13, 2024

What's the error in the panic?

at: spacewalk/pallets/vault-registry/src/benchmarking.rs:154
Error: Input("Error executing and verifying runtime benchmark: Runtime panicked: called Result::unwrap() on an Err value: Module(ModuleError { index: 21, error: [1, 0, 0, 0], message: Some(\"ExceedingVaultLimit\") })") Evicting failed runtime instance error=Runtime panicked: called Result::unwrap() on an Err value: Module(ModuleError { index: 21, error: [1, 0, 0, 0], message: Some("ExceedingVaultLimit") })

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 please only merge when CI passes though. Or if it fails because of a shaky test we can also think about merging but there at least shouldn't be any build issues.

@b-yap
Copy link
Contributor

b-yap commented Mar 13, 2024

I cancelled the CI since there's another one running. I'll rerun it afterwards.

@b-yap b-yap changed the base branch from main to dev/milestone-3 March 19, 2024 12:28
@b-yap b-yap changed the base branch from dev/milestone-3 to main March 19, 2024 12:28
@ebma ebma merged commit 5b2d982 into main Mar 19, 2024
1 check failed
@ebma ebma deleted the 496-run-benchmarks-for-all-custom-pallets branch March 19, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run benchmarks for all custom pallets
3 participants