-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pendulum metadata #485
Conversation
This is required to install subxt-cli because otherwise it wouldn't compile anymore
@@ -107,9 +107,7 @@ mod metadata_aliases { | |||
if #[cfg(feature = "standalone-metadata")] { | |||
pub type EncodedCall = metadata::runtime_types::spacewalk_runtime_standalone::RuntimeCall; | |||
} else if #[cfg(feature = "parachain-metadata-pendulum")] { | |||
pub type EncodedCall = metadata::runtime_types::foucoco_runtime::RuntimeCall; | |||
// TODO Eventually change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to do this in my 4FC-05 draft PR; I guess I don't need to anymore.
When any changes are made to elements associated with the pallets, such as extrinsic names or parameters, it is necessary to regenerate the metadata. Subxt is employed specifically for this purpose. | ||
When any changes are made to elements associated with the pallets, such as extrinsic names or parameters, it is | ||
necessary to regenerate the metadata. Subxt is employed specifically for this purpose. | ||
Note: The `--version 14` flag is required when connecting to runtime nodes that are running older Substrate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this commit is the relevant one and it seems to only be included starting with polkadot-v1.0.0 and not even polkadot-v0.9.43
. I updated the description.
Thanks for the remarks. I did some testing and found that we cannot bump the rust-toolchain version until we update all the substrate dependencies. There are plenty of related tickets e.g. this, and the issue got fixed in newer Substrate versions (which we are not yet using). |
I ran the tests and clippy checks locally and it works fine. Probably again shaky tests in our CI. |
subxt
. This is blocked until the latest runtime upgrade with the Spacewalk pallets goes live on Pendulum.Closes #484.