Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pendulum metadata #485

Merged
merged 9 commits into from
Feb 8, 2024
Merged

Update Pendulum metadata #485

merged 9 commits into from
Feb 8, 2024

Conversation

ebma
Copy link
Member

@ebma ebma commented Jan 31, 2024

  • Change the configuration to use pendulum's metadata instead of foucoco
  • Download the latest metadata.scale and metadata.json file from pendulum using subxt. This is blocked until the latest runtime upgrade with the Spacewalk pallets goes live on Pendulum.

Closes #484.

@ebma ebma linked an issue Jan 31, 2024 that may be closed by this pull request
@ebma ebma marked this pull request as ready for review February 6, 2024 12:48
@ebma ebma requested a review from a team February 6, 2024 12:48
@@ -107,9 +107,7 @@ mod metadata_aliases {
if #[cfg(feature = "standalone-metadata")] {
pub type EncodedCall = metadata::runtime_types::spacewalk_runtime_standalone::RuntimeCall;
} else if #[cfg(feature = "parachain-metadata-pendulum")] {
pub type EncodedCall = metadata::runtime_types::foucoco_runtime::RuntimeCall;
// TODO Eventually change to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to do this in my 4FC-05 draft PR; I guess I don't need to anymore.

When any changes are made to elements associated with the pallets, such as extrinsic names or parameters, it is necessary to regenerate the metadata. Subxt is employed specifically for this purpose.
When any changes are made to elements associated with the pallets, such as extrinsic names or parameters, it is
necessary to regenerate the metadata. Subxt is employed specifically for this purpose.
Note: The `--version 14` flag is required when connecting to runtime nodes that are running older Substrate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe need a definition of what "old" is.
Substrate v0.9.42 and below? Below Substrate version 1.0?
Or
old repo vs new repo ?

Copy link
Member Author

@ebma ebma Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this commit is the relevant one and it seems to only be included starting with polkadot-v1.0.0 and not even polkadot-v0.9.43. I updated the description.

@ebma
Copy link
Member Author

ebma commented Feb 6, 2024

Thanks for the remarks. I did some testing and found that we cannot bump the rust-toolchain version until we update all the substrate dependencies. There are plenty of related tickets e.g. this, and the issue got fixed in newer Substrate versions (which we are not yet using).

@ebma
Copy link
Member Author

ebma commented Feb 6, 2024

The CI is failing because the Stellar testnet is facing issues after the reset. Let's try again tomorrow.
image

@ebma
Copy link
Member Author

ebma commented Feb 8, 2024

I ran the tests and clippy checks locally and it works fine. Probably again shaky tests in our CI.

@b-yap b-yap self-requested a review February 8, 2024 09:41
@ebma ebma merged commit 7777c32 into main Feb 8, 2024
0 of 2 checks passed
@ebma ebma deleted the 484-update-pendulum-metadata branch February 8, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Pendulum metadata
2 participants