-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
431 Add environment variable options to Spacewalk #483
431 Add environment variable options to Spacewalk #483
Conversation
eb6310d
to
f5ef6db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but is there a reason not to make all configuration parameters available as environment variables? We don't really use the ones that you didn't add but they could be useful for other users.
@ebma I added env option for ALL args. |
…ob/21312266773?pr=483#step:11:17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I guess there is no way to spit out all available names of environment variables from the vault binary, I think it's best to give each env variable the very same name as the config item. Then it's at least somewhat obvious which names are used/available.
Co-authored-by: Marcel Ebert <[email protected]>
closes #431
adding the ff. arguments an ENV option:
note for AUTO_REGISTER: since the value must be a tuple, make sure to enclose it with double quotes.
🙅 ❌
export AUTO_REGISTER=0,GA5ZSEJYB37JRC5AVCIA5MOP4RHTM335X2KGX3IHOJAPP5RE34K4KZVN:USDC,1000000
❌ 🙅✅ 👌
export AUTO_REGISTER="0,GAKNDFRRWA3RPWNLTI3G4EBSD3RGNZZOY5WKWYMQ6CQTG3KIEKPYWAYC:USDC,1000000"
👌 ✅For arguments that accept
option
, make sure to enclose it with double quotes with the ACTUAL value.🙅 ❌
export MAX_NOTIFS_PER_SUBSCRIPTION="1"
❌ 🙅🙅 ❌
export MAX_NOTIFS_PER_SUBSCRIPTION="Some(1)"
❌ 🙅✅ 👌
export MAX_NOTIFS_PER_SUBSCRIPTION=1
👌 ✅