-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Polkadot SDK 1.6.0 #510
base: main
Are you sure you want to change the base?
Conversation
… compile for benchmarks
@@ -468,8 +475,9 @@ impl pallet_balances::Config for Runtime { | |||
type ReserveIdentifier = ReserveIdentifier; | |||
type FreezeIdentifier = (); | |||
type MaxFreezes = (); | |||
type MaxHolds = ConstU32<1>; | |||
type MaxHolds = ConstU32<2>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, we get an error MaxHolds should be greater than or equal to the number of hold reasons: 1 < 2
, which is an internal check of the pallet.
Apparently the RuntimeHoldReason
has 2 variants.
@@ -719,6 +745,7 @@ parameter_types! { | |||
pub const Burn: Permill = Permill::from_percent(0); | |||
pub const TreasuryPalletId: PalletId = PalletId(*b"py/trsry"); | |||
pub const MaxApprovals: u32 = 100; | |||
pub const PayoutSpendPeriod: BlockNumber = 30 * DAYS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I selected this arbitrarily. We might want to change.
@@ -1005,6 +1042,8 @@ parameter_types! { | |||
pub const MaxSubAccounts: u32 = 100; | |||
pub const MaxAdditionalFields: u32 = 100; | |||
pub const MaxRegistrars: u32 = 20; | |||
pub const ByteDeposit: Balance = MILLIUNIT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also arbitrary and we may tweak to our business req.
} | ||
|
||
impl cumulus_pallet_dmp_queue::Config for Runtime { | ||
type RuntimeEvent = RuntimeEvent; | ||
type XcmExecutor = XcmExecutor<XcmConfig>; | ||
type ExecuteOverweightOrigin = EnsureRoot<AccountId>; | ||
type DmpSink = frame_support::traits::EnqueueWithOrigin<MessageQueue, RelayOrigin>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pallet is deprecated, but we keep it to until it drains it's messages (to the replacement), assuming there are some after the update.
More info on the original PR.
} | ||
|
||
use parachains_common::message_queue::NarrowOriginToSibling; | ||
impl pallet_message_queue::Config for Runtime { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This general queue pallet can work as dmp, xcmp, etc. We use it now as a replacement for the deprecated dmp_queue
pallet.
TODO
cargo check
does not work yet.try-runtime
CLI tests, to verify the storage version updates.pendulum-chain
.Important Note
Package
runtime-integration-tests
will not be updated on this PR, as it requires further dependency refactor that potentially consist of moving all polkadot dependencies to it'scrates-io
definition (mostly due to the removal ofasset-hub
runtimes frompolkadot-sdk
).Closes #505.