Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "393 use fee per second from asset metadata in xcm config" #431

Merged

Conversation

ebma
Copy link
Member

@ebma ebma commented Mar 14, 2024

Reverts #410.

In order not to block the higher priority changes for the dependency upgrade to v0.9.42 and the PINK token registration, we'll roll back the changes from the main branch for now and merge them again at a later point in time. As far as I can tell this is the only thing that needs to get rolled back.

@ebma ebma requested a review from a team March 14, 2024 14:24
Copy link
Contributor

@gianfra-t gianfra-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It was indeed only a402b6204cbcb8cac5bb4d2801628f8a91bae683 that had to be removed.

Copy link
Contributor

@TorstenStueber TorstenStueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the output of git diff 4dda8b6 (the commit before merging #393) 5f878f0 (the commit of this PR) and the only changes are indeed only the changes of the two PRs that happened in between: #428 and #429.

So, looks good to me too.

@ebma ebma merged commit 93e1b44 into main Mar 14, 2024
2 checks passed
@ebma ebma deleted the revert-410-393-use-fee_per_second-from-asset-metadata-in-xcm-config branch March 14, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants