Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom metadata and parameters for asset registry #398

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Add custom metadata and parameters for asset registry #398

merged 2 commits into from
Jan 18, 2024

Conversation

bogdanS98
Copy link
Contributor

Closes #392 .

@bogdanS98 bogdanS98 linked an issue Jan 17, 2024 that may be closed by this pull request
Add custom metadata and parameters for asset registry #392
Closed
@bogdanS98 bogdanS98 requested a review from a team January 17, 2024 16:55
gianfra-t
gianfra-t reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@gianfra-t gianfra-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! just left one comment.

runtime/common/src/asset_registry.rs Show resolved Hide resolved
ebma
ebma approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me then

@bogdanS98 bogdanS98 merged commit b786560 into main Jan 18, 2024
2 checks passed
@bogdanS98 bogdanS98 deleted the 392-add-custom-metadata-and-parameters-for-asset-registry branch January 18, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianfra-t gianfra-t gianfra-t left review comments

@TorstenStueber TorstenStueber TorstenStueber approved these changes

@ebma ebma ebma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom metadata and parameters for asset registry
4 participants
@bogdanS98 @ebma @TorstenStueber @gianfra-t