Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task 126 add the proxy pallet #325

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

b-yap
Copy link
Contributor

@b-yap b-yap commented Oct 18, 2023

Closes https://github.com/pendulum-chain/tasks/issues/126

The code and the amounts are coming from Astar.

I've expressed the amounts required per chain.

@b-yap b-yap requested a review from a team October 18, 2023 07:42
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the comments. Otherwise, I think it's fine to just use Astar's configuration values. Configuration looks good overall.

runtime/amplitude/src/lib.rs Outdated Show resolved Hide resolved
runtime/common/src/proxy_type.rs Outdated Show resolved Hide resolved
runtime/foucoco/src/lib.rs Outdated Show resolved Hide resolved
@b-yap b-yap force-pushed the 126-task-add-the-proxy-pallet-for-all-runtimes branch from 2a6c0c1 to 04bca97 Compare November 10, 2023 23:54
@b-yap b-yap merged commit 9e59729 into main Nov 13, 2023
2 checks passed
@b-yap b-yap deleted the 126-task-add-the-proxy-pallet-for-all-runtimes branch November 13, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants