265 audit pdm 003 test coverage #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
force-pushed
the
265-audit-pdm-003-test-coverage
branch
from
e157dff to
6bb68f3
Compare
b-yap
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more test cases to the
orml-currencies-allowance-extensionpallet. The coverage was increased from 22% to 73.13%.I attached the generated report in a zip file but you can reproduce the result by running the cargo tarpaulin command
The coverage report will be placed in
./tarpaulin-report/tarpaulin-report.html.Note that while #265 is also asking for test coverage of the chain extension, I decided not to include any tests for this as it seems to be very complex to test chain extensions per se. I checked Astar's repository but they also don't seem to have any tests for this.
Closes #265.
tarpaulin-report.html.zip