Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

305 add clients info crate for spacewalk to pendulum #309

Merged

Conversation

gianfra-t
Copy link
Contributor

@gianfra-t gianfra-t commented Sep 14, 2023

Adds pallet to hold and handle vault client information.

The pallet is added to both Foucoco and Amplitude.

@pendulum-chain/product: This PR adds changes to the runtime that require a runtime upgrade to take effect.

Closes #305

@gianfra-t gianfra-t linked an issue Sep 14, 2023 that may be closed by this pull request
@gianfra-t gianfra-t requested a review from ebma September 14, 2023 18:42
runtime/amplitude/Cargo.toml Outdated Show resolved Hide resolved
runtime/foucoco/Cargo.toml Outdated Show resolved Hide resolved
@ebma
Copy link
Member

ebma commented Sep 29, 2023

@gianfra-t the CI job failed and it seems like the errors are related to dependency version mismatches actually.. 🤔 Can you have another look at it?

@gianfra-t
Copy link
Contributor Author

Done, Sorry I left some lingering revisions pointing to the previous one.

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gianfra-t gianfra-t merged commit 86c61b1 into main Oct 3, 2023
2 checks passed
@gianfra-t gianfra-t deleted the 305-add-clients-info-crate-for-spacewalk-to-pendulum branch October 3, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clients-info crate for Spacewalk to Foucoco and Amplitude runtime
2 participants