increase contract function parameter limit #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strange that the test-code job failed without indicating any reason. |
|
I re-ran the failed job and it passed. Ready for merge |
ashneverdawn
force-pushed
the
increase-contract-function-parameter-limit
branch
2 times, most recently
from
11ae740 to
184ff47
Compare
ashneverdawn
force-pushed
the
increase-contract-function-parameter-limit
branch
from
184ff47 to
04f63b5
Compare
ebma
approved these changes
May 11, 2023
TorstenStueber
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increases the contract function parameter limit to 16, to match ethereum's limit.
This is needed because 0xAmber is blocked because it has functions with more parameters than our current limit.
See: #225 (comment)