add Pendulum assets to Nova wallet #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
reviewed
Oct 25, 2024
chains/v20/chains_dev.json
Outdated
| "precision": 12, | ||
| "type": "orml", | ||
| "priceId": "euro-coin", | ||
| "icon": "https://raw.githubusercontent.com/novasamatech/nova-utils/master/icons/tokens/white/EUR.svg", |
There was a problem hiding this comment.
The icon here is for Mykobo's EURC. We should use the icon for the EURC issued by circle.
There was a problem hiding this comment.
@prayagd I can see that the linked icon folder only has the EURC.svg for Mykobo. Can we also have the Circle EURC icon as an SVG please?
There was a problem hiding this comment.
Sorry somehow missed this message, will share it here
There was a problem hiding this comment.
There was a problem hiding this comment.
i already had a EURC circle.svg but nevermind
|
I added the other icon and will now create a pull request to the upstream repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/pendulum-chain/tasks/issues/365
Added the following assets:
It looks like USDT has been added already.
I only updated v20 and v21, because both are the only versions with more assets. I only updated
chain_dev.json, based on Gianni's previous PR.