Fix defaulting to non-primary language in some cases #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the primary language of the system is English, but there is a secondary language (ie. multiple languages in QLocale::system().uiLanguages()), then the English locale will not match any translation files. It will then check the secondary language, and if that does match a translation file, then that language will be used instead of English. This issue is fixed simply by having an English translation file.
scribblemaniac
added
Bug
Translation
UI
|
Thanks @scribblemaniac. Transifex should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an occasionally complained about, never elaborated upon issue of Pencil2D starting up for the first time with the incorrect language. Fixes #1700. Probably related to #1628.
If the primary language of the system is English, but there is a secondary language (ie. multiple languages in QLocale::system().uiLanguages()), then the English locale will not match any translation files. It will then check the secondary language, and if that does match a translation file, then that language will be used instead of English. This issue is fixed simply by having an English translation file.
@chchwy Can you please merge this and handle any changes that may need to be made to Transifex?