-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode: Follow RFC3339 spec for LocalTime #632
Encode: Follow RFC3339 spec for LocalTime #632
Conversation
@pelletier I took the liberty of removing the skip statement for the failing testgen case, but since one of the subcases is covered in #626 and not here, the CI tests will fail. If you inspect the workflow run log, you'll notice that the only failing case is
Let me know what I should do 🙂 |
RFC3339 specifies a `T` between date and time, not a space[1]. [1]: https://pkg.go.dev/time#pkg-constants Resolves: part of pelletier#613
398673e
to
8b2dd6e
Compare
Looks like the tests for |
Thank you for the patch! |
Issue: #613
Fixes 2/3 failing subcases for
go test -tags testsuite -run TestTOMLTest_Valid_Datetime_Local
:local
space
Note that the remaining failing case is addressed by #626.
The fix for this was quite straightforward: RFC3339 specifies a
as the
T
between date and time, not aString()
method onLocalDateTime
was formatting. Seego/time
constants for verification: https://pkg.go.dev/time#pkg-constants .