Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unchecked conversion between integer types on 32bit architectures #777

Closed
1 task done
pelletier opened this issue May 10, 2022 · 0 comments · Fixed by #778
Closed
1 task done

Unchecked conversion between integer types on 32bit architectures #777

pelletier opened this issue May 10, 2022 · 0 comments · Fixed by #778
Labels
bug Issues describing a bug in go-toml.

Comments

@pelletier
Copy link
Owner

pelletier commented May 10, 2022 •
edited
Loading

go-toml/unmarshaler.go

Line 939 in b2e0231

r = reflect.ValueOf(uint(i))

On a 32bit platform uint can be uint32. So this code needs to validate that i is actually less than uint on the current platform. Not a problem on 64bit architectures where uint is uint64.

Tracking issue for:
@pelletier pelletier added the bug Issues describing a bug in go-toml. label May 10, 2022
pelletier added a commit that referenced this issue May 10, 2022
@pelletier
Decoder: check max uint on 32 bit platforms
fc1a11d 
Fixes #777
@pelletier pelletier mentioned this issue May 10, 2022
Merged
pelletier added a commit that referenced this issue May 10, 2022
@pelletier
Decoder: check max uint on 32 bit platforms (#778)
0a422e3 
Fixes #777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues describing a bug in go-toml.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decode: check max uint on 32 bit platforms pelletier/go-toml
1 participant
@pelletier