Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Port parameter for Abiotic Factor #136

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

dougmaitelli
Copy link
Contributor

Description

I just tried to use the current egg to setup Abiotic Factor and it was not working at all, after a lot of tests I found out the parameter in the egg is wrong for port, it should be Port and not PORT

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

Copy link
Contributor

@gOOvER gOOvER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you didnt export the egg from the panel

@dougmaitelli
Copy link
Contributor Author

you didnt export the egg from the panel

I figured I didn't need to since this is an already existing egg. I can export it but it comes with the wrong parameter on the export.

you didnt export the egg from the panel

done now

Copy link
Contributor

@QuintenQVD0 QuintenQVD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuintenQVD0 QuintenQVD0 merged commit 2af3298 into pelican-eggs:main Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants