Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include feature id in results where MultiPolygon #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewharvey
Copy link

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change 🚀

lookup.search where the Feature was a Polygon, returns the GeoJSON exactly as supplied including an id field, however that was broken when the Feature was a MultiPolygon.


Here's what actually got changed 👏

where the indexed feature had an id, then include it is the search result.


Here's how others can test the changes 👀

I first updated the unit test based on what should work, found it failed the test, then fixed the code, then found it passed.

andrewharvey added a commit to alantgeo/vicmap2osm that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant