Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring whether disused/abandoned venues are removed #537

Closed
orangejulius opened this issue Jul 2, 2020 · 1 comment
Closed
Assignees

Comments

@orangejulius
Copy link
Member

Currently, our popularity mapper from #493/ #531 also causes any venues with low popularity (usually those marked as disused or abandoned in OSM) to be removed, and not imported into Pelias:

// discard places with a negative popularity
else if( popularity < 0 ){ return next(); }

This might be a reasonable default, but it's also pretty significant. There might be a lot of notable places that fall into those categories. We should look at adding a configuration option to enable or disable removal of those venues.

@orangejulius orangejulius self-assigned this Jul 23, 2020
orangejulius added a commit that referenced this issue Jul 28, 2020
As described in #537, the
default set in #493, where
all venues that have a calculated popularity below `0` are not imported,
is a bit strict.

This adds a config flag, `imports.openstreetmap.removeDisusedVenues`
that controls whether or not that behavior is activated.

In addition, when enabled, a `warning` is displayed for each removed
record.
@orangejulius
Copy link
Member Author

This was fixed in #539: by default we will now continue to import these venues, but there is a configuration option to remove them if desired.

This was referenced Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant