support for dynamically specifying the elasticsearch _type from config #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icsearch _type from config
This was referenced Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pairs with pelias/config#118 & pelias/schema#401
the motivation is being able to create indices compatible with ES7 while not yet breaking backwards support for ES5.
this allows us to create ES7 compatible indices using either ES6 or ES7 without breaking backwards compatibility with 5 yet.
the major motivation for this is that users currently building on
pelias/dockeron ES6 are going to find that the indices they created with ES6 (using_type:doc) are incompatible with ES7 (and also incompatible with ES6 once we change the type name to_doc!)that doesn't really make sense, so I plan to set the
config.schema.typeNamevariable to_docinpelias/dockerprojects so that indices built with ES6 will not incur any breaking changes.this is much preferred because without it any users migrating to ES6 would assume that in doing so they were avoiding breaking changes when in fact that wasn't true.