Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inifinte loop with invalid hostname #212

Merged
merged 3 commits into from
Aug 7, 2024
Merged

fix inifinte loop with invalid hostname #212

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b113f0
fix inifinte loop with invalid hostname
arnesetzer Jul 25, 2024
11f544c
fix spacing
arnesetzer Jul 26, 2024
d49f771
add hostname to error message invalid hostname
arnesetzer Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/request_urls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ function request_urls(config, urls, callback) {
request( requestOpts, function ( err, res ){
if( err ){
console.error( err );
//Check if hostname is valid. Abort execution if not
if( err.code === 'ENOTFOUND' ) {
throw new Error( 'Invalid hostname: "'+ err.hostname + '". Stopping execution.' );
}
urls.push(url);
}
else if( shouldRetryRequest(res) ){
Expand Down