Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @orangejulius I've been noticing a bunch of my test cases failing with the message
"no results returned"
against thev1
code.the error is caused when the elasticsearch client times out a query with the message
"Request Timeout after 3000ms"
, we used to returnstatusCode:500
for this error but now we returnstatusCode:200
andfeatures: []
with the message parroted back to the user in the geojson asres.geocoding.errors[0]
eg.
this PR is not really that nice (code wise) so that's totally open for a rewrite but at least it shows a place in the code where we may be able to handle this case and maybe retry those queries? I guess we wouldn't want to retry them indefinitely; because DOS.
thoughts?