Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to enabling libpostal in the api #59

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Default to enabling libpostal in the api #59

merged 1 commit into from
Jun 2, 2017

Conversation

orangejulius
Copy link
Member

At this point, using addressit for search and structured search is
basically an unsupported configuration, since we haven't tested it in
some time. It may in fact even cause errors like those seen in
pelias/pelias#579.

@orangejulius orangejulius self-assigned this May 22, 2017
@missinglink
Copy link
Member

I take it this doesn't have any effect on autocomplete?

@orangejulius
Copy link
Member Author

No, autocomplete would stay the same. This PR is the same as setting textAnalyzer: "libpostal" in pelias.json, which is what we all do on our dev machines and what happens in production for Mapzen Search. The autocomplete endpoint isn't configured to use libpostal under any circumstances.

@orangejulius orangejulius requested review from dianashk and trescube June 2, 2017 20:08
trescube
trescube requested changes Jun 2, 2017
View reviewed changes
Copy link
Contributor

@trescube trescube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property is named textAnalyzer

@orangejulius
Default to enabling libpostal in the api
06521bf 
At this point, using addressit for search and structured search is
basically an unsupported configuration, since we haven't tested it in
some time. It may in fact even cause errors like those seen in
pelias/pelias#579.
@orangejulius
Copy link
Member Author

Hah. good catch. I got it right in the comment though :P

@trescube
Copy link
Contributor

trescube commented Jun 2, 2017

nice, finally forcing libpostal upon the world!

@orangejulius orangejulius merged commit 25fb82a into master Jun 2, 2017
@dianashk dianashk removed the in review label Jun 2, 2017
@orangejulius orangejulius deleted the default-libpostal branch October 23, 2017 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trescube trescube trescube approved these changes

@dianashk dianashk Awaiting requested review from dianashk

Assignees

@orangejulius orangejulius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orangejulius @missinglink @trescube @dianashk