Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1502 #1640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issue #1502 #1640

wants to merge 1 commit into from

Conversation

stefanocudini
Copy link

this allows you to use pelias-api in a slightly different environment as a library.
I also think it is a bit more elegant solution, considering that including an md file as a result of an api rest endpoint is already quite a whimsical thing :)

I wish you good work

@stefanocudini
Copy link
Author

stefanocudini commented Nov 7, 2022

@missinglink @orangejulius could you please accept this small contribution? it is useful for my prod systems and I have made it a generic feature, the code is simple and clean.
It would be nice to have it in the next versions

@missinglink
Copy link
Member

missinglink commented Nov 7, 2022

Hi @stefanocudini, I've fixed the core issue in #1642, we never intended this use-case (use as a library) but it should now be possible.

I don't want to encourage users to remove the attribution route, it's a legal requirement for the use of the data, and gives credit to the maintainers of the project and contributors.

That being said, the app variable returned by addRoutes() can be modified in your application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants