fix stable sorting on node 11.6.0 #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice |
|
Wait, can you explain how this fixes the problem? Node.js 11 includes v8 version 7 which changes Array.prototype.sort to be stable by default. So my understanding is that using the |
|
@missinglink I came across this again and was wondering if you could chime in with how this fixes things, as I mentioned in my last comment, before we forget everything about it. |
|
honestly, I'm not really sure, I was working on another issue when I discovered this error. so I just quickly fixed it and got back to the original task. |
|
Is it possible that the stable sorting algorithms are different between core and the stable module? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit tests are failing on node 11.6.0 due to unstable sorting, this PR fixes the issue and tests pass on both 10 & 11 now.