Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOOK-1146 updated bookie to sort nodes based on latency #23

Open
wants to merge 3 commits into
base: pbsa-develop
Choose a base branch
from
Open

BOOK-1146 updated bookie to sort nodes based on latency #23

wants to merge 3 commits into from

Conversation

aametzler
Copy link

No description provided.

@aametzler aametzler requested a review from mseaward March 22, 2019 17:38
@aametzler aametzler self-assigned this Mar 22, 2019
@aametzler aametzler changed the title updated bookie to sort nodes based on latency BOOK-1146 updated bookie to sort nodes based on latency Mar 22, 2019
mseaward
mseaward previously approved these changes Mar 22, 2019
View reviewed changes
MuffinLightning pushed a commit that referenced this pull request Apr 1, 2019
@mseaward
Merge pull request #23 from PBSA/BOOK-733-Update-loading-your-transac…
42e55eb 
…tion-history-loading-image

BOOK-733: Update loading your transaction history loading image
@mseaward mseaward added the story/feature New feature or request label Apr 2, 2019
@mseaward mseaward self-requested a review April 5, 2019 15:19
@mseaward mseaward dismissed their stale review April 5, 2019 15:22

change base

@mseaward mseaward changed the base branch from develop to pbsa-develop April 11, 2019 11:44
mseaward
mseaward suggested changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@mseaward mseaward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try Again button should not be redoing the latency list sorting.

  • should be done once and re-used after doing sorting initially on application launch.

pbsa-github pushed a commit that referenced this pull request Aug 26, 2020
@mseaward
Merge pull request #23 from PBSA/BOOK-733-Update-loading-your-transac…
42af0df 
…tion-history-loading-image

BOOK-733: Update loading your transaction history loading image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mseaward mseaward mseaward approved these changes

@MuffinLightning MuffinLightning Awaiting requested review from MuffinLightning

At least 1 approving review is required to merge this pull request.

Assignees

@aametzler aametzler

Labels
story/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aametzler @mseaward @mamokin