Add delay and maximum change rate for commission #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfffaaa
reviewed
Jan 15, 2025
pallets/parachain-staking/src/lib.rs
Outdated
|
|
||
| /// The maximum permill that a commission can change in one go. | ||
| #[pallet::constant] | ||
| type MaxCommissionChange: Get<Permill>; |
There was a problem hiding this comment.
During yesterday's discussion, let us make a sudo extrinsic to set that because
- It'll be easier for the business team to decide the parameters later. Significantly if they change their mind, we don't need to do more runtime upgrades for that
- It will be easier for us to test this feature
There was a problem hiding this comment.
working on that already 👍
…udo user able to change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.