-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add wildcard and prefix support to cat #736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denizsurmeli
requested changes
Jul 9, 2024
seruman
reviewed
Jul 11, 2024
seruman
reviewed
Jul 11, 2024
seruman
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
igungor
approved these changes
Jul 16, 2024
denizsurmeli
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the cat command in s5cmd to support wildcard and prefix operations, improving its flexibility and usability for users. It includes comprehensive test cases.
Wildcard Support:
Example:
s5cmd cat s3://bucket/foo*
concatenates content of files with paths starting withs3://bucket/foo
. Use quotation marks according to your terminal type (e.g., bash, zsh).Prefix Support:
Enables cat to concatenate all files within a specified directory. Ignores nested folders.
Example:
s5cmd cat s3://bucket/dir/
concatenates content of all files within the "dir" directory. But would not match with files insides3://bucket/dir/another_folder/
. Wildcard characters can be used for this case.Resolves: #716