-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
command/sync: handle object listing errors #597
Merged
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
da7d6fa
command/sync: handle object listing errors
ahmethakanbesel 4589b09
command/sync: fix typo in the comments
ahmethakanbesel 899a195
command/sync: fix typo in the comments
ahmethakanbesel 9482b08
command/sync: add --exit-on-error flag
ahmethakanbesel ea069b4
command/sync: better error handling
ahmethakanbesel 2bf614d
command/sync: add new tests
ahmethakanbesel 219c8a6
command/sync: update not found bucket test
ahmethakanbesel b89f6d3
command/sync: update tests
ahmethakanbesel d3aea4e
command/sync: refactor getSourceAndDestinationObjects
ahmethakanbesel 127ff9b
command/run: check ctx cancelled
ahmethakanbesel c6318bb
Merge branch 'peak:master' into sync-handle-errors
ahmethakanbesel 15b3d58
command/sync: revert refactoring
ahmethakanbesel 10ee234
command/run: revert a change
ahmethakanbesel c85c3ba
command/sync: add a test case
ahmethakanbesel 8230b85
changelog: add a bug fix
ahmethakanbesel 17b199c
Merge branch 'master' into sync-handle-errors
ahmethakanbesel 68f2b4a
changelog: fix typo
ahmethakanbesel c3fdf8b
Merge branch 'master' into sync-handle-errors
ahmethakanbesel 966ce06
command/sync: add fallthrough
ahmethakanbesel 723fcf3
Merge branch 'master' into sync-handle-errors
ahmethakanbesel 209ae93
Merge branch 'master' into sync-handle-errors
ahmethakanbesel 11c1435
changelog: update the entry
ahmethakanbesel 427ffb4
Merge branch 'master' into sync-handle-errors
ahmethakanbesel ff52dea
Merge branch 'master' into sync-handle-errors
ilkinulas 06619ef
command/sync: refactor `shouldStopSync`
ahmethakanbesel 6f5e1ff
Merge branch 'master' into sync-handle-errors
ahmethakanbesel 44261f2
command/sync: revert the ctx
ahmethakanbesel 96fd166
command/run: set reader err if ctx is cancelled
ahmethakanbesel 1189724
command/run: remove unnecessary `return`
ahmethakanbesel 7b79b43
Merge branch 'master' into sync-handle-errors
sonmezonur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
command/sync: add a test case
- Loading branch information
commit c85c3ba764fadcf5acb68d207aa1f37693403033
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case does not adequately test the
--exit-on-error
flag, because if the bucket does not exist, the flag will have no effect. It would be better to test the flag with an error other than "AccessDenied" or "NoSuchBucket".