Make it possible to override content-type and content-encoding from CLI arguments #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattofriends
requested review from
aykutfarsak and
sonmezonur
and removed request for
a team
|
Oops, didn't notice #466 exists too |
nattofriends
force-pushed
the
content-type-content-encoding-overridable
branch
from
5490824 to
330c26c
Compare
sonmezonur
reviewed
Jul 18, 2022
aykutfarsak
approved these changes
Jul 19, 2022
|
@nattofriends Thanks for your contribution. Could you please update CHANGELOG? |
|
@nattofriends Also, adding examples to cp help text would be useful. |
nattofriends
force-pushed
the
content-type-content-encoding-overridable
branch
from
9a4774d to
8d7ca99
Compare
sonmezonur
approved these changes
Jul 20, 2022
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets users override Content-Type and Content-Encoding headers, to close #264. #318 is a similar PR which added the --cache-control and --expires options.