Treat "connection reset" errors as retryable. #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per aws/aws-sdk-go#2926 (comment), the upstream SDK doesn't retry connection reset errors on reads, because at that point we can't tell if the server has already applied the operation. For S3 operations, I think pretty much all requests should be safely idempotent, so I think we should retry these errors. I saw some of my own long-running jobs fail this weekend due to network weather and some dropped connections that s5cmd did not retry, which I found very surprising. Per aws/aws-sdk-go@c3d2710, the `strings.Contains` check does seem to be the best way to check for this error.
nelhage
requested review from
igungor and
ilkinulas
and removed request for
a team
igungor
approved these changes
Jun 16, 2021
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per
aws/aws-sdk-go#2926 (comment),
the upstream SDK doesn't retry connection reset errors on reads,
because at that point we can't tell if the server has already applied
the operation.
For S3 operations, I think pretty much all requests should be safely
idempotent, so I think we should retry these errors.
I saw some of my own long-running jobs fail this weekend due to
network weather and some dropped connections that s5cmd did not retry,
which I found very surprising.
Per
aws/aws-sdk-go@c3d2710,
the
strings.Containscheck does seem to be the best way to check forthis error.
This might fix #294, or there might be something deeper going on there.