Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: Hugo version v0.102.0+ on macos support #605

Open
3 tasks done
erdaltsksn opened this issue Sep 1, 2022 · 3 comments · May be fixed by #609
Open
3 tasks done

support: Hugo version v0.102.0+ on macos support #605

erdaltsksn opened this issue Sep 1, 2022 · 3 comments · May be fixed by #609
Assignees
Labels
enhancement New feature or request

Comments

@erdaltsksn
Copy link

erdaltsksn commented Sep 1, 2022

Checklist

  • I am using the latest version of this action.
  • I have read the latest README and followed the instructions.
  • I have read the latest GitHub Actions official documentation and learned the basic spec and concepts.

Describe your question

In version v0.102.0:

  • The macOS archives have been replaced with universal/fat binaries that work on all macOS platforms, named macOS-universal.tar.gz.
  • These archives are removed: 32-bit Linux archives, Windows 32-bit and ARM, Linux ARM Deb. We may re-add some of these if enough people shout.

https://github.com/gohugoio/hugo/releases/tag/v0.102.0

Relevant links

YAML config:
      - name: Set up Hugo
        uses: peaceiris/actions-hugo@v2
        with:
          hugo-version: 0.102.2
          extended: true

Relevant log output

Run peaceiris/actions-hugo@v2
  with:
    hugo-version: 0.102.2
    extended: true
Hugo version: 0.102.2
##[debug]Hugo extended: true
##[debug]Operating System: macOS
##[debug]Processor Architecture: 64bit
##[debug]toolURL: https://github.com/gohugoio/hugo/releases/download/v0.102.2/hugo_extended_0.102.2_macOS-64bit.tar.gz
##[debug]homeDir: /Users/runner
##[debug]workDir: /Users/runner/actions_hugo
##[debug]binDir: /Users/runner/actions_hugo/bin
##[debug]tempDir: /Users/runner/actions_hugo/_temp
##[debug]Downloading https://github.com/gohugoio/hugo/releases/download/v0.102.2/hugo_extended_0.102.2_macOS-64bit.tar.gz
##[debug]Destination /Users/runner/work/_temp/22756f02-0de5-4cda-bb34-c76a19a75ce2
##[debug]Failed to download from "https://github.com/gohugoio/hugo/releases/download/v0.102.2/hugo_extended_0.102.2_macOS-64bit.tar.gz". Code(404) Message(Not Found)
Error: Action failed with error Unexpected HTTP response: 404
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Set up Hugo
@erdaltsksn erdaltsksn added the support User support label Sep 1, 2022
@peaceiris
Copy link
Owner

👀

@peaceiris peaceiris changed the title support: Hugo version v0.102.0+ support support: Hugo version v0.102.0+ on macos support Sep 2, 2022
@peaceiris
Copy link
Owner

The Hugo macOS release asset has been renamed in v0.102.0

- https://github.com/gohugoio/hugo/releases/download/v0.101.0/hugo_extended_0.101.0_macOS-64bit.tar.gz
+ https://github.com/gohugoio/hugo/releases/download/v0.102.0/hugo_extended_0.102.0_macOS-universal.tar.gz

I will work on this.

@peaceiris peaceiris added enhancement New feature or request and removed support User support labels Sep 2, 2022
@peaceiris peaceiris pinned this issue Sep 2, 2022
babar-raza added a commit to Aspose/products.aspose.com-workflows that referenced this issue Sep 23, 2022
hardcoded the Hugo version to avoid issue as mentioned in peaceiris/actions-hugo#605
@erdaltsksn
Copy link
Author

The Hugo macOS release asset has been renamed in v0.102.0

- https://github.com/gohugoio/hugo/releases/download/v0.101.0/hugo_extended_0.101.0_macOS-64bit.tar.gz
+ https://github.com/gohugoio/hugo/releases/download/v0.102.0/hugo_extended_0.102.0_macOS-universal.tar.gz

I will work on this.

Any update?

I don't know typescript but putting something like if the version is 0.102.0 or later, assign arch as universal should fix it.

File: get-url.ts

babar-raza added a commit to Aspose/products.aspose.com-workflows that referenced this issue Oct 5, 2022
michaeltlombardi added a commit to michaeltlombardi/actions-hugo that referenced this issue Oct 6, 2022
Prior to this change, the URL building for versions of hugo was
deterministic as the URLs for the packages were set to a
project-specific standard. That URL creation began to fail for macOS in
[0.102.0] and for Windows in [0.103.0]. It does not fail for Linux
because the hugo releases for Linux continue to include the old package
naming as an alias.

This change:

- Updates the `get-os` function to take the hugo version as additional
  input, altering the return value based on the version.
- Updates the `get-arch` function to take the operating system name and
  hugo version as additional input, altering the return value based on
  both. Including the OS name is required for handling macOS.
- Fixes peaceiris#608
- Fixes peaceiris#605
michaeltlombardi added a commit to michaeltlombardi/actions-hugo that referenced this issue Oct 6, 2022
Prior to this change, the URL building for versions of hugo was
deterministic as the URLs for the packages were set to a
project-specific standard. That URL creation began to fail for macOS in
[0.102.0] and for Windows in [0.103.0]. It does not fail for Linux
because the hugo releases for Linux continue to include the old package
naming as an alias.

This change:

- Updates the `get-os` function to take the hugo version as additional
  input, altering the return value based on the version.
- Updates the `get-arch` function to take the operating system name and
  hugo version as additional input, altering the return value based on
  both. Including the OS name is required for handling macOS.
- Fixes peaceiris#608
- Fixes peaceiris#605

[0.102.0]: https://github.com/gohugoio/hugo/releases/tag/v0.102.0
[0.103.0]: https://github.com/gohugoio/hugo/releases/tag/v0.103.0
jaaufauvre added a commit to manixate/jest-hugo that referenced this issue Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants