set selectTextStyle propType to Text.propTypes.style

[mienaikoe]

#25

[peacechen]

Thanks @mienaikoe

React native allows both style objects and arrays for style properties. For example:

style={[styles.default, {color:'red'}, this.props.overrideStyle]}

It would be more flexible to allow both. Just noticed that all the other style props should be updated the same way :)

[mienaikoe]

Sure, Maybe that should be done under a different issue ticket tho.

[peacechen]

If it's not too much trouble, would you mind updating all the style props with PropTypes.oneOfType ? I won't be able to get to it right now and it'll likely fall through the cracks with my bad memory :D

[mikaello]

I have tried to investigate prop types for arrays in style-properties, but it seems that this is somehow included in Text.propTypes.style (and other prop types for styles from RN). There is no warning in debug-mode when using arrays without explicit specifying it.

In Text from RN all properties goes trough a function which flattens any array present. So as far as I can see Text.propTypes.style accepts both objects and arrays with objects. ViewPropTypes uses the same function.

Other well maintained react-native modules seem to just use Text.propTypes.style, and not PropTypes.oneOfType to include array, e.g. react-native-elements Search inputStyle.

So I think this PR is good to go, and no further editing is necessary.

[peacechen]

Thanks @mikaello for clarifying the style proptypes behavior. Wasn't aware that arrays are automatically flattened first.