Cleanup for v0.6 release. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Whitespace fixes - Move FQN to `use` statements - Use PHP source functions instead of alias - Collpase multi-if statements - Inline function returns - Remove commented out code
- Add divider comment between generic and specific sections - Grab composer from official docker image rather than web - Use a more robust shell - Make apt-install footprint smaller - Use OpenSSL with paths rather than use WORKDIR - Make project path setable through env var for build purposes - Only install non-dev dependencies with composer. The develop shoudl consciencely install deve dependencies because of develop PHP version(s) used. - Use COPY rather than ADD as per best practices
Potherca
force-pushed
the
release/v0.6
branch
from
5847196 to
396d93f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.